Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 86.28% 85.31% -0.98%
==========================================
Files 22 22
Lines 1750 1777 +27
==========================================
+ Hits 1510 1516 +6
- Misses 240 261 +21
Continue to review full report at Codecov.
|
Owner
|
Seems very interesting ! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a draft pull-request (i.e. no test, no doc yet). I would be happy to get feedback to know if maintainers are interested by such a feature. If so, I will take time to make it cleaner including docs, samples and tests.
It's great being able to provide an album download link thanks to
zip_galleryplugin. Nonetheless, on my Sigal instance, it is a seldomly used feature. Thus, having many zip archives on my hard drive which duplicates all my original pictures is a waste of disk storage.The idea of this pull-request is to make Sigal generate NGINX
mod_zip"manifest" instead of real zip archives. Then, on user request, a properly configured NGINX will take care of dynamically generating the zip archive using the "manifest".P.S.: I've currently re-used
zip_gallerysince it's very similar job (only the output result change), not sure it's the best approach though.